[GH-ISSUE #330] Today filter triggers on any post with the same day of month #54

New issue

Closed

opened 2026-09-29 12:59:08 +00:00 by slurdge · 2 comments

slurdge commented

2026-09-29 12:59:08 +00:00

Owner

Originally created by @BrandonDusseau on GitHub (Jul 13, 2026).
Original GitHub issue: https://github.com/slurdge/goeland/issues/330

I've been experiencing some weirdness with the "today" filter for a while, which I've only been able to pin down now. It seems the filter matches on any post with the same day of the month that hasn't yet been recorded, regardless of which month or year it was published.

For example, today (July 13) I received a digest with posts dated June 13. Looking at my previous emails, they arrived like this:

July 6 - received posts dated June 6
July 2 - received post dated April 2
June 27 - received posts dated April 27

In my case since I set my cron expression to run only once early in the morning, this caused all posts to be delayed by at least a month as well.

To Reproduce
A portion of my configuration:

loglevel = "info"
run-at-startup = false
database = "/data/goeland.db"
include-header = false

[sources]
[sources.phpbb]
url = "https://www.phpbb.com/community/feed/forum/14"
type="feed"
filters = ["today", "includelink", "includesourcetitle", "digest"]

[pipes]
[pipes.phpbb]
disabled = false
source = "phpbb"
destination = "email"
email_to = ["redacted"]
email_from = "redacted"
email_title = "{{.EntryTitle}}"
cron = "0 6 * * *"

Steps to reproduce the behavior:

Configure a source with the "today" and possibly "digest" filters (see above).
Trigger delivery of the digest.
Observe that all unseen posts matching the day number are returned.

Expected behavior
Only posts from the current day should be delivered.

Screenshots
N/A

OS: Linux Mint (Docker)
Version v0.24.0

Originally created by @BrandonDusseau on GitHub (Jul 13, 2026). Original GitHub issue: https://github.com/slurdge/goeland/issues/330 I've been experiencing some weirdness with the "today" filter for a while, which I've only been able to pin down now. It seems the filter matches on any post with the same day of the month that hasn't yet been recorded, regardless of which month or year it was published. For example, today (July 13) I received a digest with posts dated June 13. Looking at my previous emails, they arrived like this: * July 6 - received posts dated June 6 * July 2 - received post dated April 2 * June 27 - received posts dated April 27 In my case since I set my cron expression to run only once early in the morning, this caused all posts to be delayed by at least a month as well. **To Reproduce** A portion of my configuration: ```toml loglevel = "info" run-at-startup = false database = "/data/goeland.db" include-header = false [sources] [sources.phpbb] url = "https://www.phpbb.com/community/feed/forum/14" type="feed" filters = ["today", "includelink", "includesourcetitle", "digest"] [pipes] [pipes.phpbb] disabled = false source = "phpbb" destination = "email" email_to = ["redacted"] email_from = "redacted" email_title = "{{.EntryTitle}}" cron = "0 6 * * *" ``` Steps to reproduce the behavior: 1. Configure a source with the "today" and possibly "digest" filters (see above). 2. Trigger delivery of the digest. 3. Observe that all unseen posts matching the day number are returned. **Expected behavior** Only posts from the current day should be delivered. **Screenshots** N/A - OS: Linux Mint (Docker) - Version v0.24.0

slurdge closed this issue

2026-09-29 12:59:08 +00:00

slurdge commented

2026-09-29 12:59:08 +00:00

Author

Owner

@slurdge commented on GitHub (Jul 13, 2026):

Whoah !!! Nice catch !
I've glanced at the code and yep, here it is:

func filterToday(source *goeland.Source, params *filterParams) {
	var current int
	for _, entry := range source.Entries {
		if entry.Date.Day() != time.Now().Day() {
			continue
		}
		source.Entries[current] = entry
		current++
	}
	source.Entries = source.Entries[:current]
}

My bad thinking the "day" part what the actual day and not the day of the month. I'll fix it later today.

@slurdge commented on GitHub (Jul 13, 2026): Whoah !!! Nice catch ! I've glanced at the code and yep, here it is: ``` func filterToday(source *goeland.Source, params *filterParams) { var current int for _, entry := range source.Entries { if entry.Date.Day() != time.Now().Day() { continue } source.Entries[current] = entry current++ } source.Entries = source.Entries[:current] } ``` My bad thinking the "day" part what the _actual_ day and not the day of the month. I'll fix it later today.

slurdge commented

2026-09-29 12:59:09 +00:00

Author

Owner

@slurdge commented on GitHub (Jul 13, 2026):

@BrandonDusseau should be fixed in latest version !

@slurdge commented on GitHub (Jul 13, 2026): @BrandonDusseau should be fixed in latest version !

slurdge referenced this issue

2026-09-29 12:59:27 +00:00

[PR #54] [MERGED] chore(deps): bump github.com/sirupsen/logrus from 1.8.1 to 1.9.0 #89