[PR #384] [MERGED] fix: close Miniflux mark-as-read response bodies #377

New issue

Closed

opened 2026-10-07 20:02:03 +00:00 by slurdge · 0 comments

slurdge commented

2026-10-07 20:02:03 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/slurdge/goeland/pull/384
Author: @bensynapse
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @slurdge

Base: master ← Head: fix-miniflux-response-close

📝 Commits (1)

034c391 fix: close Miniflux mark-as-read response bodies

📊 Changes

2 files changed (+119 additions, -0 deletions)

View changed files

📝 internal/goeland/fetch/miniflux.go (+1 -0)
➕ internal/goeland/fetch/miniflux_test.go (+118 -0)

📄 Description

I run Live Tennis API.

With mark-as-read enabled, fetchMiniflux leaves the PUT response body open. Its existing defer closes only the earlier GET response. Nonempty error responses keep connection resources until the client timeout.

The PUT body now closes on both successful marks and unexpected HTTP statuses. Two local HTTP regressions fail before this fix and pass afterward. They also check GET body closure, entry parsing and the mark-as-read payload.

make test, go test -race -json ./..., make build and go vet ./... pass on Go 1.26.0. The race run passes all 132 test and subtest markers. Containerized GOFLAGS=-race make test also passes on Go 1.26.8.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/slurdge/goeland/pull/384 **Author:** [@bensynapse](https://github.com/bensynapse) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@slurdge](https://github.com/slurdge) **Base:** `master` ← **Head:** `fix-miniflux-response-close` --- ### 📝 Commits (1) - [`034c391`](https://github.com/slurdge/goeland/commit/034c391c09ac187f4c31787cb2a8acea337a0449) fix: close Miniflux mark-as-read response bodies ### 📊 Changes **2 files changed** (+119 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `internal/goeland/fetch/miniflux.go` (+1 -0) ➕ `internal/goeland/fetch/miniflux_test.go` (+118 -0) </details> ### 📄 Description I run Live Tennis API. With `mark-as-read` enabled, `fetchMiniflux` leaves the PUT response body open. Its existing defer closes only the earlier GET response. Nonempty error responses keep connection resources until the client timeout. The PUT body now closes on both successful marks and unexpected HTTP statuses. Two local HTTP regressions fail before this fix and pass afterward. They also check GET body closure, entry parsing and the mark-as-read payload. `make test`, `go test -race -json ./...`, `make build` and `go vet ./...` pass on Go 1.26.0. The race run passes all 132 test and subtest markers. Containerized `GOFLAGS=-race make test` also passes on Go 1.26.8. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>