[GH-ISSUE #43] Youtube/Odysee links lost from EEVblog RSS feed #16

Closed
opened 2026-09-29 12:58:38 +00:00 by slurdge · 5 comments
Owner

Originally created by @kriswilk on GitHub (Jun 12, 2022).
Original GitHub issue: https://github.com/slurdge/goeland/issues/43

As I was migrating feeds into goeland, I noticed this one seems to lose its video links:

https://www.eevblog.com/feed/

Probably a consequence of how they're referenced in the feed content (the src of an iframe, within a figure). Any way to preserve these?

Originally created by @kriswilk on GitHub (Jun 12, 2022). Original GitHub issue: https://github.com/slurdge/goeland/issues/43 As I was migrating feeds into goeland, I noticed this one seems to lose its video links: https://www.eevblog.com/feed/ Probably a consequence of how they're referenced in the feed content (the src of an iframe, within a figure). Any way to preserve these?
Author
Owner

@slurdge commented on GitHub (Jun 13, 2022):

Yes this is due to the fact that goeland sanitize the feed before applying filters. I could specifically allow some URLs (look at this issue: https://github.com/microcosm-cc/bluemonday/issues/120) but I think it's somewhat not a good solution.

<!-- gh-comment-id:1153858895 --> @slurdge commented on GitHub (Jun 13, 2022): Yes this is due to the fact that goeland sanitize the feed before applying filters. I could specifically allow some URLs (look at this issue: https://github.com/microcosm-cc/bluemonday/issues/120) but I think it's somewhat not a good solution.
Author
Owner

@slurdge commented on GitHub (Jun 13, 2022):

I'm looking to have a special func on iframes what would extract the link on retrieve filter.

<!-- gh-comment-id:1153902221 --> @slurdge commented on GitHub (Jun 13, 2022): I'm looking to have a special func on iframes what would extract the link on `retrieve` filter.
Author
Owner

@slurdge commented on GitHub (Jun 21, 2022):

I have a current implementation that works but I really don't like it, basically, I do a special processing in order to extract iframe links.

I plan to completely change that with the following:

  1. Introduce a --unsafe-no-sanitize-filter command line option along with a configuration file option unsafe-no-sanitize-filter.
  2. Sanitizing will be moved to a first and special filter (I still have to see if there are no processing before).
  3. Sanitizing filter will be made available as a regular filter.

That way, it should be possible to download eevblog RSS, do no sanitation, replace the

<!-- gh-comment-id:1161471546 --> @slurdge commented on GitHub (Jun 21, 2022): I have a current implementation that works but I really don't like it, basically, I do a special processing in order to extract iframe links. I plan to completely change that with the following: 1. Introduce a `--unsafe-no-sanitize-filter` command line option along with a configuration file option `unsafe-no-sanitize-filter`. 2. Sanitizing will be moved to a first and special filter (I still have to see if there are no processing before). 3. Sanitizing filter will be made available as a regular filter. That way, it should be possible to download eevblog RSS, do no sanitation, replace the <iframe>, do sanitation and have a proper email. @kriswilk By the way, the links are for the embedded version of the videos, so it's not a direct link to youtube.
Author
Owner

@slurdge commented on GitHub (Aug 4, 2022):

I have made the changes in order to not "sanitize" the input and it does work. However it seems that most (all ?) email clients are blocking iframes anyway. @kriswilk Do you have a special email client in mind ?

<!-- gh-comment-id:1205441472 --> @slurdge commented on GitHub (Aug 4, 2022): I have made the changes in order to not "sanitize" the input and it does work. However it seems that most (all ?) email clients are blocking iframes anyway. @kriswilk Do you have a special email client in mind ?
Author
Owner

@slurdge commented on GitHub (Aug 4, 2022):

v0.11.0 should be good for this issue.

<!-- gh-comment-id:1205532945 --> @slurdge commented on GitHub (Aug 4, 2022): v0.11.0 should be good for this issue.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: slurdge/goeland#16
No description provided.