[PR #83] [MERGED] feat: add password_file option #114

New issue

Closed

opened 2026-09-29 12:59:38 +00:00 by slurdge · 0 comments

slurdge commented

2026-09-29 12:59:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/slurdge/goeland/pull/83
Author: @sweenu
Created: 11/4/2022
Status: ✅ Merged
Merged: 11/5/2022
Merged by: @slurdge

Base: master ← Head: add-pass-file

📝 Commits (1)

e9b3322 feat: add password_file option

📊 Changes

3 files changed (+16 additions, -0 deletions)

View changed files

📝 README.md (+2 -0)
📝 cmd/run.go (+11 -0)
📝 config/config.go (+3 -0)

📄 Description

It's becoming pretty standard to be able to set secrets with an environment variable finishing with _FILE. Unfortunately, viper does not do it by default: https://github.com/spf13/viper/issues/1022.

The viper.SetEnvKeyReplacer(replacer) line is taken from https://github.com/spf13/viper/issues/239#issuecomment-248318912.

I'm currently in the process of packaging goeland for NixOS, this will make things simpler and more secure.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/slurdge/goeland/pull/83 **Author:** [@sweenu](https://github.com/sweenu) **Created:** 11/4/2022 **Status:** ✅ Merged **Merged:** 11/5/2022 **Merged by:** [@slurdge](https://github.com/slurdge) **Base:** `master` ← **Head:** `add-pass-file` --- ### 📝 Commits (1) - [`e9b3322`](https://github.com/slurdge/goeland/commit/e9b332274d533232b8acd65f05228505b97c2fa5) feat: add password_file option ### 📊 Changes **3 files changed** (+16 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+2 -0) 📝 `cmd/run.go` (+11 -0) 📝 `config/config.go` (+3 -0) </details> ### 📄 Description It's becoming pretty standard to be able to set secrets with an environment variable finishing with `_FILE`. Unfortunately, viper does not do it by default: https://github.com/spf13/viper/issues/1022. The `viper.SetEnvKeyReplacer(replacer)` line is taken from https://github.com/spf13/viper/issues/239#issuecomment-248318912. I'm currently in the process of packaging goeland for NixOS, this will make things simpler and more secure. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>