[PR #82] [MERGED] feat: get config from standard places #110

New issue

Closed

opened 2026-09-29 12:59:37 +00:00 by slurdge · 0 comments

slurdge commented

2026-09-29 12:59:37 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/slurdge/goeland/pull/82
Author: @sweenu
Created: 11/4/2022
Status: ✅ Merged
Merged: 11/5/2022
Merged by: @slurdge

Base: master ← Head: config-directories

📝 Commits (1)

9471b13 feat: get config from standard places

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 config/config.go (+2 -0)

📄 Description

I think the creation of the config file should also be in those directories: $XDG_CONFIG_HOME/goeland/config.toml and if does not exist /etc/goeland/config.toml.
The database should also probably go in $XDG_STATE_HOME/goeland/goeland.db or /var/lib/goeland/goeland.db.

And to support macOS and windows as much, something like https://github.com/adrg/xdg could be used.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/slurdge/goeland/pull/82 **Author:** [@sweenu](https://github.com/sweenu) **Created:** 11/4/2022 **Status:** ✅ Merged **Merged:** 11/5/2022 **Merged by:** [@slurdge](https://github.com/slurdge) **Base:** `master` ← **Head:** `config-directories` --- ### 📝 Commits (1) - [`9471b13`](https://github.com/slurdge/goeland/commit/9471b137abf587b20b4d42f018965060a9b48933) feat: get config from standard places ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `config/config.go` (+2 -0) </details> ### 📄 Description I think the creation of the config file should also be in those directories: `$XDG_CONFIG_HOME/goeland/config.toml` and if does not exist `/etc/goeland/config.toml`. The database should also probably go in `$XDG_STATE_HOME/goeland/goeland.db` or `/var/lib/goeland/goeland.db`. And to support macOS and windows as much, something like https://github.com/adrg/xdg could be used. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>