[PR #78] [MERGED] fix: default to SSLTLS encryption when port is 465 #109

New issue

Closed

opened 2026-09-29 12:59:36 +00:00 by slurdge · 0 comments

slurdge commented

2026-09-29 12:59:36 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/slurdge/goeland/pull/78
Author: @sweenu
Created: 11/1/2022
Status: ✅ Merged
Merged: 11/1/2022
Merged by: @slurdge

Base: master ← Head: master

📝 Commits (1)

fa44112 fix: default to SSLTLS encryption when port is 465

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 cmd/run.go (+3 -0)

📄 Description

I spent an hour trying to understand why the SMTP connection would timeout. I just didn't expect the default encryption to be STARTTLS. Figured it out by looking at the code.
I propose this PR to be a little bit smarter about which encryption to default to.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/slurdge/goeland/pull/78 **Author:** [@sweenu](https://github.com/sweenu) **Created:** 11/1/2022 **Status:** ✅ Merged **Merged:** 11/1/2022 **Merged by:** [@slurdge](https://github.com/slurdge) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`fa44112`](https://github.com/slurdge/goeland/commit/fa44112602c0962a2a5e65d05c60f43c97bc5b26) fix: default to SSLTLS encryption when port is 465 ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `cmd/run.go` (+3 -0) </details> ### 📄 Description I spent an hour trying to understand why the SMTP connection would timeout. I just didn't expect the default encryption to be STARTTLS. Figured it out by looking at the code. I propose this PR to be a little bit smarter about which encryption to default to. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>